Print the multicast group id along with the number of packets replicated. #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 24, 2024 18:41
Signed-off-by: Bara Kopi <[email protected]>
Signed-off-by: Bara Kopi <[email protected]>
angelazhang8
force-pushed
the
print_mgid
branch
from
a25183b to
93b371b
Compare
jafingerhut
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
LGTM. @smolkaj You might want to check this to see if the updated BMv2 log output would require adjustments to anything you do that check the logs, and/or pass this PR on to others to double-check.
|
Should be fine for us. We're trying to use this extra information to extract information from the logs more effectively. Would appreciate if you could merge it when you get a chance @jafingerhut, since I don't have the relevant authorizations. But approved on my and @smolkaj's (who's out until Feb) behalf. |
jonathan-dilorenzo
approved these changes
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.