Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an API to get TableInfo from ConstraintInfo through a lookup using table_id #111

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

angelazhang8
Copy link
Contributor

@angelazhang8 angelazhang8 commented Oct 20, 2023

Add an API to get TableInfo from ConstraintInfo through a lookup using table_id.

This is part of a larger effort to not expose p4-constraints internals to clients, so we can change internals without breaking clients.

…g table_id

Code in P4 fuzzer uses ConstraintInfo to lookup TableInfo. Since p4fuzzer presubmit checks that any new code added to p4infra Github builds, we need to first sync this change to p4infra Github. This CL will enable these changes: https://critique.corp.google.com/cl/574299826. This is part of the work to support actions in P4-constraints by allowing users to add constraint annotations for actions. Please see the design doc at https://docs.google.com/document/d/11Nkn3_BAa43OX4I-_DPsoUokebGdRYx6QAk7eGVAyLc/edit?resourcekey=0-gO31LvkRyylb07KB1m3RMg for more information.

PUBLIC: [p4-fuzzer] Add ConstraintInfo API for retrieving TableInfo given table_id.
PiperOrigin-RevId: 574581354
@onf-cla-manager
Copy link

Hi @angelazhang8, this is the ONF bot 🤖 I'm glad you want to contribute to our projects! However, before accepting your contribution, we need to ask you to sign a Contributor License Agreement (CLA). You can do it online, it will take only a few minutes:

✒️ 👉 https://cla.opennetworking.org

After signing, make sure to add your Github user ID angelazhang8 to the agreement.

For more information or help:"
https://wiki.opennetworking.org/x/BgCUI

Copy link
Member

@smolkaj smolkaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@smolkaj smolkaj merged commit d054e74 into master Oct 20, 2023
3 checks passed
@smolkaj smolkaj deleted the cl/574581354 branch October 20, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants