PUBLIC: [p4-constraints] Remove EntryMeetsConstraint and replace with ReasonEntryViolatesConstraint in tests. #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ReasonEntryViolatesConstraint in tests. EntryMeetsConstraint and ReasonEntryViolatesConstraint share common code. It was decided that we should keep ReasonEntryViolatesConstraint as it provides output that explains why an entry violated a constraint, whereas EntryMeetsConstraint does not. Tests were changed accordingly to use ReasonEntryViolatesConstraint. Documentation for https://github.com/p4lang/p4-constraints has been updated in another CL. PiperOrigin-RevId: 581321018
smolkaj
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PUBLIC: [p4-constraints] Remove EntryMeetsConstraint and replace with ReasonEntryViolatesConstraint in tests.
EntryMeetsConstraint and ReasonEntryViolatesConstraint share common code. It was decided that we should keep ReasonEntryViolatesConstraint as it provides output that explains why an entry violated a constraint, whereas EntryMeetsConstraint does not. Tests were changed accordingly to use ReasonEntryViolatesConstraint. Documentation for https://github.com/p4lang/p4-constraints has been updated in another CL.