[p4-constraints] Allow C++ compliant multi-line strings. #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-dilorenzo
force-pushed
the
cl/628166543
branch
from
a4ae043 to
bcee3fb
Compare
|
This is a workaround to a combination of p4lang/p4c#2333 and an issue where the C++ preprocessor inserts line directives into our original workaround (making everything one big, single string). |
I.e. strings like: ``` "This is the start of my string " "and this is the end." ``` This will help solve a C++ preprocessor issue we're having where it will randomly insert preprocessor directives into the `@entry_restriction` annotation string when using a single multi-line string. PiperOrigin-RevId: 628166543
jonathan-dilorenzo
force-pushed
the
cl/628166543
branch
from
bcee3fb to
b136fd0
Compare
smolkaj
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[p4-constraints] Allow C++ compliant multi-line strings.
I.e. strings like:
This will help solve a C++ preprocessor issue we're having where it will randomly insert preprocessor directives into the
@entry_restrictionannotation string when using a single multi-line string.