Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded version from workflow #194

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kin0992
Copy link

@kin0992 kin0992 commented Dec 18, 2024

List of changes

  • Enable corepack
  • Use turbo on major version 2

Motivation and context

We want to use the latest turbo version in our workflows.

Type of changes

  • Add new resources
  • Update configuration to existing resources
  • Remove existing resources

Does this introduce a change to production resources with possible user impact?

  • Yes, users may be impacted applying this change
  • No

It can impact those projects that are pointing to main when referencing the updated workflow.

Other information

There is a PR that shows how to migrate from turbo 1 to version 2.
Reference: pagopa/trial-system#267

Migration guide

First, check the official documentation for any doubts.

  • Run yarn dlx @turbo/codemod migrate or npx @turbo/codemod migrate (official tool that should help to migrate. Follow the wizard)
    • This will update the turbo.json file and try to install the latest version of turbo
      • In case of errors, you can manually update the turbo.json file following these steps
      • In case it wasn't possible to install turbo, try to do it manually:
        • yarn add -D turbo
      • Now you should be ready to use the latest version of turbo
  • Eventually, update the workflow pointing to a specific SHA

Copy link

changeset-bot bot commented Dec 18, 2024

⚠️ No Changeset found

Latest commit: 175afe7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Comment on lines +52 to +53
- name: Enable Corepack
run: corepack enable
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: required to use proper version of yarn

@kin0992 kin0992 marked this pull request as ready for review December 18, 2024 14:28
@kin0992 kin0992 requested a review from a team as a code owner December 18, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants