Add app_command_line to java based app services #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 45adaae The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mamu0
approved these changes
Dec 19, 2024
gunzip
reviewed
Dec 20, 2024
| @@ -9,6 +9,10 @@ locals { | |||
| zone_balancing_enabled = local.tier != "s" && local.tier != "xs" | |||
| is_slot_enabled = local.tier == "s" || local.tier == "xs" ? 0 : 1 | |||
| always_on = local.tier == "xs" ? false : true | |||
| command_line = { | |||
| node = null | |||
There was a problem hiding this comment.
question: is there a way to owerwrite this for the module user?
There was a problem hiding this comment.
Not in this PR, but I think @christian-calabrese could bring the changes of the #188 (still to resolve)
There was a problem hiding this comment.
We can surely do it, I'll integrate it in this PR as soon as we find the correct solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List of changes
Add app_command_line to java based app services
Motivation and context
Java based app services needs the application startup command to be set by the user to launch the jar file.
Type of changes
Does this introduce a change to production resources with possible user impact?
Other information