bug: [PagoPa-2421] - advisory lock #277

alessio-acitelli · 2024-12-13T16:17:29Z

Depends on: INFRA PAGOPA-2421

List of Changes

changed some configurations to prevent the advisory lock problem

Motivation and Context

Error: Failed to execute goal org.flywaydb:flyway-maven-plugin:8.0.5:migrate (default-cli) on project gpd: org.flywaydb.core.api.FlywayException: Unable to release PostgreSQL advisory lock

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.

…/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

https://github.com/pagopa/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

…/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

https://github.com/pagopa/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

https://github.com/pagopa/pagopa-debt-position.git into PAGOPA-2421-advisory-lock Conflicts: pom.xml

https://github.com/pagopa/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

…/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

https://github.com/pagopa/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

…/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

https://github.com/pagopa/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

…/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

pasqualespica · 2024-12-16T13:48:22Z

helm/values-dev.yaml

@@ -86,6 +86,7 @@ microservice-chart:
    WEBSITE_SITE_NAME: 'pagopa-d-gpd-core-service'
    ENV: 'dev'
    SPRING_DATASOURCE_URL: "jdbc:postgresql://gpd-db.d.internal.postgresql.pagopa.it:6432/apd?sslmode=require&prepareThreshold=0&tcpKeepAlive=true"
+    FLYWAY_DATASOURCE_URL: "jdbc:postgresql://gpd-db.d.internal.postgresql.pagopa.it:6432/apd?sslmode=require&prepareThreshold=0&tcpKeepAlive=true&lock_timeout=30000"


why add FLYWAY_DATASOURCE_URL if isnt'used ?and for flyway migration doesn't use6432( pgbouncer ) but directly5432`

pasqualespica · 2024-12-16T13:50:28Z

apdFlywayConfig.conf

@@ -1,4 +1,4 @@
 flyway.user=${SPRING_DATASOURCE_USERNAME}
 flyway.password=${SPRING_DATASOURCE_PASSWORD}
 flyway.schemas=${GPD_SCHEMA_NAME}
-flyway.url=${SPRING_DATASOURCE_URL}
+flyway.url=${FLYWAY_DATASOURCE_URL}


export SPRING_DATASOURCE_URL='${{ secrets.DATASOURCE_URL }}'
is set via .identity

we need to add a new one secret

env_secrets = { ... "DATASOURCE_URL": data.azurerm_key_vault_secret.key_vault_datasource_url.value, }

something like FLYWAY_DATASOURCE_URL
that use dns, 5432 and new param lock_timeout=30000 that tou hare rich out

pasqualespica · 2024-12-16T13:50:40Z

helm/values-prod.yaml

@@ -86,6 +86,7 @@ microservice-chart:
    WEBSITE_SITE_NAME: 'pagopa-p-gpd-core-service'
    ENV: 'prod'
    SPRING_DATASOURCE_URL: "jdbc:postgresql://gpd-db.p.internal.postgresql.pagopa.it:6432/apd?sslmode=require&prepareThreshold=0"
+    FLYWAY_DATASOURCE_URL: "jdbc:postgresql://gpd-db.p.internal.postgresql.pagopa.it:6432/apd?sslmode=require&prepareThreshold=0&lock_timeout=30000"


pasqualespica · 2024-12-16T13:50:46Z

helm/values-uat.yaml

@@ -86,6 +86,7 @@ microservice-chart:
    WEBSITE_SITE_NAME: 'pagopa-u-gpd-core-service'
    ENV: 'uat'
    SPRING_DATASOURCE_URL: "jdbc:postgresql://gpd-db.u.internal.postgresql.pagopa.it:6432/apd?sslmode=require&prepareThreshold=0&tcpKeepAlive=true"
+    FLYWAY_DATASOURCE_URL: "jdbc:postgresql://gpd-db.u.internal.postgresql.pagopa.it:6432/apd?sslmode=require&prepareThreshold=0&tcpKeepAlive=true&lock_timeout=30000"


pasqualespica · 2024-12-16T13:51:14Z

pom.xml

@@ -19,7 +19,7 @@
        <springdoc-version>1.6.6</springdoc-version>
        <modelmapper-version>3.1.0</modelmapper-version>
        <jackson-datatype-jsr310-version>2.13.1</jackson-datatype-jsr310-version>
-        <flyway-version>8.5.13</flyway-version>
+        <flyway-version>9.22.3</flyway-version>


it works for pgFlex 15 vers too ?

From 9.0.5 Flyway is compatible with PostgreSQL 15:
https://documentation.red-gate.com/fd/release-notes-for-flyway-engine-179732572.html

Abou PGFLEX: "The compatibility includes PostgreSQL-specific features and extensions such as custom schema handling and advanced SQL functions. However, Flyway itself does not explicitly manage extensions like pgFlex. To use such extensions, you need to ensure they are installed and configured in your PostgreSQL instance prior to running Flyway migrations"

https://github.com/pagopa/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

pasqualespica

lgtm 🆗

github-actions · 2024-12-18T17:13:48Z

This pull request does not contain a valid label. Please add one of the following labels: [major, minor, patch, patch, skip]

sonarqubecloud · 2024-12-18T17:16:15Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

aacitelli added 3 commits December 13, 2024 10:23

[PAGOPA-2421] advisory lock: update conf to prevent lock

4f98b08

[PAGOPA-2421] advisory lock: update conf to prevent lock

afa3f26

Merge branch 'PAGOPA-2421-advisory-lock' of https://github.com/pagopa…

cae300d

…/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

github-actions bot assigned alessio-acitelli Dec 13, 2024

github-actions bot added the size/small label Dec 13, 2024

aacitelli added 3 commits December 13, 2024 17:27

Merge branch 'PAGOPA-2421-advisory-lock' of

cc070f5

https://github.com/pagopa/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

Merge branch 'PAGOPA-2421-advisory-lock' of https://github.com/pagopa…

1a3ae9d

…/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

Merge branch 'PAGOPA-2421-advisory-lock' of

94d39dd

https://github.com/pagopa/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

alessio-acitelli had a problem deploying to dev December 13, 2024 16:56 — with GitHub Actions Failure

alessio-acitelli temporarily deployed to dev December 15, 2024 18:35 — with GitHub Actions Inactive

alessio-acitelli had a problem deploying to dev December 15, 2024 18:35 — with GitHub Actions Failure

alessio-acitelli temporarily deployed to dev December 15, 2024 18:38 — with GitHub Actions Inactive

aacitelli and others added 9 commits December 16, 2024 12:05

[PAGOPA-2421] advisory lock: flyway 9

cc1a1f2

Merge branch 'PAGOPA-2421-advisory-lock' of

cefbc80

https://github.com/pagopa/pagopa-debt-position.git into PAGOPA-2421-advisory-lock Conflicts: pom.xml

Merge branch 'PAGOPA-2421-advisory-lock' of

7318195

https://github.com/pagopa/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

Merge branch 'PAGOPA-2421-advisory-lock' of https://github.com/pagopa…

ccf8164

…/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

Merge branch 'PAGOPA-2421-advisory-lock' of

fb6bcd6

https://github.com/pagopa/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

Merge branch 'PAGOPA-2421-advisory-lock' of https://github.com/pagopa…

d548ee4

…/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

Merge branch 'PAGOPA-2421-advisory-lock' of

26d82e5

https://github.com/pagopa/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

Merge branch 'PAGOPA-2421-advisory-lock' of https://github.com/pagopa…

c8eea53

…/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

Merge branch 'main' into PAGOPA-2421-advisory-lock

b59d1ab

alessio-acitelli temporarily deployed to dev December 16, 2024 11:42 — with GitHub Actions Inactive

alessio-acitelli temporarily deployed to dev December 16, 2024 11:43 — with GitHub Actions Inactive

alessio-acitelli temporarily deployed to dev December 16, 2024 11:45 — with GitHub Actions Inactive

alessio-acitelli and others added 2 commits December 16, 2024 12:47

Merge branch 'main' into PAGOPA-2421-advisory-lock

15f3ca1

Merge branch 'PAGOPA-2421-advisory-lock' of https://github.com/pagopa…

7846052

…/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

alessio-acitelli marked this pull request as ready for review December 16, 2024 12:43

alessio-acitelli requested a review from a team as a code owner December 16, 2024 12:43

alessio-acitelli requested a review from pasqualespica December 16, 2024 12:43

pasqualespica requested changes Dec 16, 2024

View reviewed changes

aacitelli added 2 commits December 17, 2024 14:32

[PAGOPA-2421] advisory lock: removed flyway url from helm

c6a4f79

[PAGOPA-2421] advisory lock: identity update for flyway

0d81eab

alessio-acitelli requested a review from pasqualespica December 17, 2024 14:17

alessio-acitelli added the bug Something isn't working label Dec 17, 2024

pasqualespica approved these changes Dec 18, 2024

View reviewed changes

pasqualespica and others added 3 commits December 18, 2024 14:23

Merge branch 'main' into PAGOPA-2421-advisory-lock

ba1dec2

[PAGOPA-2421] advisory lock: fix name

f993899

Merge branch 'PAGOPA-2421-advisory-lock' of

4ae05f8

https://github.com/pagopa/pagopa-debt-position.git into PAGOPA-2421-advisory-lock

pasqualespica approved these changes Dec 18, 2024

View reviewed changes

alessio-acitelli added 2 commits December 18, 2024 18:09

Merge branch 'main' into PAGOPA-2421-advisory-lock

98989ac

Merge branch 'main' into PAGOPA-2421-advisory-lock

a265849

alessio-acitelli merged commit 2171b2e into main Dec 18, 2024
14 of 16 checks passed

alessio-acitelli deleted the PAGOPA-2421-advisory-lock branch December 18, 2024 17:19

alessio-acitelli temporarily deployed to dev December 18, 2024 17:23 — with GitHub Actions Inactive

alessio-acitelli temporarily deployed to dev December 18, 2024 17:24 — with GitHub Actions Inactive

alessio-acitelli temporarily deployed to dev December 18, 2024 17:27 — with GitHub Actions Inactive

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bug: [PagoPa-2421] - advisory lock #277

bug: [PagoPa-2421] - advisory lock #277

alessio-acitelli commented Dec 13, 2024 •

edited

Loading

pasqualespica Dec 16, 2024

pasqualespica Dec 16, 2024

pasqualespica Dec 16, 2024

pasqualespica Dec 16, 2024

pasqualespica Dec 16, 2024

alessio-acitelli Dec 16, 2024

pasqualespica left a comment

github-actions bot commented Dec 18, 2024

sonarqubecloud bot commented Dec 18, 2024

bug: [PagoPa-2421] - advisory lock #277

bug: [PagoPa-2421] - advisory lock #277

Conversation

alessio-acitelli commented Dec 13, 2024 • edited Loading

List of Changes

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

Checklist:

pasqualespica Dec 16, 2024

Choose a reason for hiding this comment

pasqualespica Dec 16, 2024

Choose a reason for hiding this comment

pasqualespica Dec 16, 2024

Choose a reason for hiding this comment

pasqualespica Dec 16, 2024

Choose a reason for hiding this comment

pasqualespica Dec 16, 2024

Choose a reason for hiding this comment

alessio-acitelli Dec 16, 2024

Choose a reason for hiding this comment

pasqualespica left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 18, 2024

sonarqubecloud bot commented Dec 18, 2024

Quality Gate passed

alessio-acitelli commented Dec 13, 2024 •

edited

Loading