-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHK-1202 ecommerce commons #37
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 Well done! I would add just a note into README about the mvn validate command to be used for build locally commons and notes for perform local test pointing to a specific branch.
Those inforations can be retrieved from here as example: https://github.com/pagopa/pagopa-ecommerce-transactions-service/blob/a124f43cedd2d99bfc4461e02c01d6b15c764b45/README.md?plain=1#L99-L122
List of Changes
pagopa-ecommerce-commons
;Motivation and Context
The goal of this PR is to use
pagopa-ecommerce-commons
and delete all custom classes migrated to this library.How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: