Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHK-1202 ecommerce commons #37

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Conversation

infantesimone
Copy link
Contributor

List of Changes

Motivation and Context

The goal of this PR is to use pagopa-ecommerce-commons and delete all custom classes migrated to this library.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@infantesimone infantesimone requested a review from a team as a code owner February 28, 2023 17:14
pietro-tota
pietro-tota previously approved these changes Feb 28, 2023
Copy link
Contributor

@pietro-tota pietro-tota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Well done! I would add just a note into README about the mvn validate command to be used for build locally commons and notes for perform local test pointing to a specific branch.
Those inforations can be retrieved from here as example: https://github.com/pagopa/pagopa-ecommerce-transactions-service/blob/a124f43cedd2d99bfc4461e02c01d6b15c764b45/README.md?plain=1#L99-L122

@infantesimone infantesimone marked this pull request as draft February 28, 2023 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants