PM-837 env variables grouped in single string

[andrearovere]

List of Changes

Environment variables for clients grouped in a single string

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.

Link to story

[alessandrodossi]

@andrearovere maven build of this branch fails: JUnit tests should be updated too

[alessandrodossi]

Why this?

[andrearovere]

Init of the Map

[alessandrodossi]

Ok, I meant:
if (!MapUtils.isEmpty(configValues)) { return; }
this fragment evaluates private Map<String, String> configValues; which is a private local variable and is always empty before evaluation, since you are using this method as first statement in each callers.
Thus, your code should always hit that "return:" and skip the instantiation.

Anyway, I don't get this statement either:
configValues = configsMap;
why should it be needed?

[alessandrodossi]

Ok, I meant:
if (!MapUtils.isEmpty(configValues)) { return; }
this fragment evaluates private Map<String, String> configValues; which is a private local variable and is always empty before evaluation, since you are using this method as first statement in each callers.
Thus, your code should always hit that "return:" and skip the instantiation.

Anyway, I don't get this statement either:
configValues = configsMap;
why should it be needed?

[alessandrodossi]

These changes need to be tested in local environment before deploying them in SIT