Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [CHK-1256] update openapi according to pagopa guidelines #245

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

infantesimone
Copy link
Contributor

@infantesimone infantesimone commented Mar 14, 2023

List of Changes

  • enrichment of the info section with description and externalDocs;
  • rename resource target with payment-authorizations;
  • refactoring request and response for xpay

Motivation and Context

The goal of this PR is to update openapi according to pagopa guidelines.

How Has This Been Tested?

https://editor.swagger.io/?url=https://raw.githubusercontent.com/pagopa/pagopa-payment-transactions-gateway/CHK-1256-review-openapi/api-specs/api_spec_PGS.yaml

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have created or updated an API interface.
    • I have updated the OpenAPI spec
  • I have created or updated a database table
    • I have updated both the Oracle and Postgres migrations
  • My PR is cohesive and self-contained (rule of thumb: less than 250 changed lines)

Link to story

@infantesimone infantesimone requested a review from a team March 14, 2023 20:15
api-specs/api_spec_PGS.yaml Outdated Show resolved Hide resolved
api-specs/api_spec_PGS.yaml Show resolved Hide resolved
api-specs/api_spec_PGS.yaml Show resolved Hide resolved
Copy link

@ciuffagianluca ciuffagianluca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

api-specs/api_spec_PGS.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants