Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[B2BP-433] - new assistance page #62

Merged
merged 8 commits into from
Jun 13, 2024
Merged

Conversation

salvatorediocaro
Copy link
Collaborator

Description
Added new assistance page, modified the "hero" of the FAQ page and modified the navigation menu

List of Changes
Modified these files : pages\faq\index.tsx, api\data\assistenza.tsx, api\index.tsx, pages\assistenza.tsx, src\layout\LandingLayout.tsx, styles\default.css, src\components\NavigationBar.tsx

Motivation and Context
Created new content and new styles

How Has This Been Tested?
Execute on locally the SEND Site

Screenshots (if appropriate):

Types of changes
New Features

Checklist:
My change not requires a change to the documentation.

added new assistance page, modified the "hero" of the FAQ page and modified the navigation menu
Copy link
Contributor

@ZorbaDimatteo ZorbaDimatteo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@salvatorediocaro there some small issues UI related to solve:

  • with a high screen dimension the toolbar has this strange behaviour
image
  • mobile drawer menu items have different vertical spacing
    image

  • in assistenza page in mobile resolutions there are issue within the toolbar (see the right side)
    image

  • menu in mobile resolutions and especially on white background is not visibile

Screenshot 2024-06-06 at 18 14 54 - internal menu in Assistenza page in mobile resolutions has some visibility issues image

Then in page /punti-di-ritiro/come-funziona/ there is a runtime error when opening the page, something related to OneTrust script upload.
Finally, resolve merge conflicts pulling by develop, reinstalling dependency through yarn install and pay attention to not include package-lock.json

salvatorediocaro and others added 7 commits June 11, 2024 12:20
Modified page "come-funziona"
Modified NavigationBar style
Modified NavigationBar style
Changed the style of the assistance page and NavigationBar
Changed some links and style of assistance page
@ZorbaDimatteo ZorbaDimatteo merged commit c90239a into develop Jun 13, 2024
3 checks passed
@ZorbaDimatteo ZorbaDimatteo deleted the radd-support-changes branch June 13, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants