Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TURN configuration #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add TURN configuration #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions roles/palava-signaltower/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ palava_signaltower_log_dir: /var/log/signaltower
palava_signaltower_port: 4233
palava_signaltower_autostart: yes

# palava_signaltower_turn_secret: TURN_SECRET__IF_GIVEN_TURN_IS_ENABLED

Copy link
Member

@janlelis janlelis Nov 16, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I have a small suggestion: We should make activation of TURN explicit, e.g. like this:

palava_signaltower_turn_enabled: no
palava_signaltower_turn_secret: ''

I think it would be better readable and less "magic"

palava_signaltower_version: master

palava_environment: production
Expand Down
5 changes: 4 additions & 1 deletion roles/palava-signaltower/templates/signaltower.service.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,11 @@ Restart=on-failure
Type=forking
RestartSec=5
Environment=SIGNALTOWER_PORT={{ palava_signaltower_port }}
{% if palava_signaltower_turn_secret|default(False) %}
Environment=SIGNALTOWER_TURN_SECRET={{ palava_signaltower_turn_secret }}
{% endif %}
Environment=LOG_FILE={{ palava_signaltower_log_dir }}/signaltower.log
SyslogIdentifier=signaltower

[Install]
WantedBy=multi-user.target
WantedBy=multi-user.target