Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opt: optimize Conn.Next and Conn.Peek #654

Merged
merged 2 commits into from
Nov 12, 2024

bug: fix the blocking issue on Windows

03716c4
Select commit
Loading
Failed to load commit list.
Merged

opt: optimize Conn.Next and Conn.Peek #654

bug: fix the blocking issue on Windows
03716c4
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 12, 2024 in 0s

78.82% (-0.08%) compared to bdd3fb6, passed because coverage increased by 0.13% when compared to adjusted base (78.68%)

View this Pull Request on Codecov

78.82% (-0.08%) compared to bdd3fb6, passed because coverage increased by 0.13% when compared to adjusted base (78.68%)

Details

Codecov Report

Attention: Patch coverage is 79.16667% with 15 lines in your changes missing coverage. Please review.

Project coverage is 78.82%. Comparing base (bdd3fb6) to head (03716c4).

Files with missing lines Patch % Lines
connection_windows.go 79.41% 14 Missing ⚠️
connection_unix.go 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #654      +/-   ##
==========================================
- Coverage   78.90%   78.82%   -0.08%     
==========================================
  Files          21       21              
  Lines        2546     2546              
==========================================
- Hits         2009     2007       -2     
- Misses        413      420       +7     
+ Partials      124      119       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.