chore: rename some parameters #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
panjf2000
force-pushed
the
interface2any
branch
from
eed4d20 to
3ef315d
Compare
interface{} --> any
itf/i --> a
queue.TaskFunc --> queue.Func
queue.Run --> queue.Exec
arg --> parameter
Also, update some comments to make more sense.
panjf2000
force-pushed
the
interface2any
branch
from
3ef315d to
47ab6a3
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #656 +/- ##
=======================================
Coverage 78.82% 78.82%
=======================================
Files 21 21
Lines 2546 2546
=======================================
Hits 2007 2007
Misses 420 420
Partials 119 119
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
interface{} --> any
itf/i --> a
queue.TaskFunc --> queue.Func
queue.Run --> queue.Exec
arg --> parameter
Also, update some comments to make more sense.