add more error handling options b00tc4mp#412

pankelix · Feb 27, 2024 · bfdbba5 · bfdbba5
1 parent e38d9a6
commit bfdbba5
Show file tree

Hide file tree

Showing 6 changed files with 50 additions and 7 deletions.
diff --git a/staff/miguel-arias/project/api/logic/assignTask.js b/staff/miguel-arias/project/api/logic/assignTask.js
diff --git a/staff/miguel-arias/project/api/logic/assignTask.test.js b/staff/miguel-arias/project/api/logic/assignTask.test.js
diff --git a/staff/miguel-arias/project/api/logic/createRoom.js b/staff/miguel-arias/project/api/logic/createRoom.js
@@ -1,5 +1,5 @@
 import { validate, errors } from 'com'
-const { SystemError } = errors
+const { SystemError, NotFoundError } = errors
 
 import { Room, Home } from '../data/models.js'
 
@@ -8,9 +8,22 @@ function createRoom(homeId, name) {
     validate.text(name, 'name')
 
     return (async () => {
+        let home
+        try {
+            home = await Home.findById(homeId).lean()
+        } catch (error) {
+            throw new SystemError(error.message)
+        }
+
+        if (!home)
+            throw new NotFoundError('home not found')
+
         try {
             const room = await Room.create({ home: homeId, name })
 
+            if (!room)
+                throw new NotFoundError('room not found')
+
             return room
         } catch (error) {
             throw new SystemError(error.message)

diff --git a/staff/miguel-arias/project/api/logic/createTask.js b/staff/miguel-arias/project/api/logic/createTask.js
@@ -1,14 +1,24 @@
 import { validate, errors } from 'com'
-const { SystemError } = errors
+const { SystemError, NotFoundError } = errors
 
-import { Task } from '../data/models.js'
+import { Task, Home } from '../data/models.js'
 
 function createTask(homeId, templateId, date/*,  assigneeId */) {
     validate.id(homeId, 'home id')
     validate.id(templateId, 'template id')
     /* validate.id(assigneeId, 'assignee id') */
 
     return (async () => {
+        let home
+        try {
+            home = await Home.findById(homeId).lean()
+        } catch (error) {
+            throw new SystemError(error.message)
+        }
+
+        if (!home)
+            throw new NotFoundError('home not found')
+
         try {
             const task = await Task.create({ home: homeId, template: templateId, date: date/*,  assignee: assigneeId */ })
 

diff --git a/staff/miguel-arias/project/api/logic/createTemplate.js b/staff/miguel-arias/project/api/logic/createTemplate.js
@@ -1,7 +1,7 @@
 import { validate, errors } from 'com'
-const { SystemError } = errors
+const { SystemError, NotFoundError } = errors
 
-import { Template } from '../data/models.js'
+import { Template, Home } from '../data/models.js'
 
 function createTemplate(homeId, name, rooms, periodicity, points) {
     validate.id(homeId, 'home id')
@@ -11,6 +11,16 @@ function createTemplate(homeId, name, rooms, periodicity, points) {
     validate.number(points, 'points')
 
     return (async () => {
+        let home
+        try {
+            home = await Home.findById(homeId).lean()
+        } catch (error) {
+            throw new SystemError(error.message)
+        }
+
+        if (!home)
+            throw new NotFoundError('home not found')
+
         try {
             const template = await Template.create({ home: homeId, name, rooms, periodicity, points })
 

diff --git a/staff/miguel-arias/project/api/logic/registerProfile.js b/staff/miguel-arias/project/api/logic/registerProfile.js
@@ -1,16 +1,26 @@
 import bcrypt from 'bcryptjs'
 
 import { validate, errors } from 'com'
-const { SystemError, DuplicityError } = errors
+const { SystemError, DuplicityError, NotFoundError } = errors
 
-import { Profile } from '../data/models.js'
+import { Profile, Home } from '../data/models.js'
 
 function registerProfile(homeId, name, pincode, color, role) {
     validate.id(homeId)
     validate.text(name, 'name')
     validate.pincode(pincode, 'pincode')
 
     return (async () => {
+        let home
+        try {
+            home = await Home.findById(homeId).lean()
+        } catch (error) {
+            throw new SystemError(error.message)
+        }
+
+        if (!home)
+            throw new NotFoundError('home not found')
+
         try {
             const hash = await bcrypt.hash(pincode, 8)