Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split 'Standard.BruteForceByIP' into IP and Username versions #1457

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ben-githubs
Copy link
Contributor

Background

Hakmiller noticed that our Standard.BruteForceByIP rule is actually checking by username, not IP. He requested we either make the title clearer, or adjust the rule to check by IP instead. Since changing a rule's title has numerous consequences, I've instead decided to adjust the logic to check by IP, and copied the existing logic to a new rule, Standard.BruteForceByUser, so customers can keep the same behaviour if they wish.

Changes

  • Title and dedup changes to Standard.BruteForceByIP
  • Added new rule Standard.BruteForceByUser, which has the original logic of Standard.BruteForceByIP
  • Updated standard pack to include new rule

Testing

  • Titles and dedups for both rules work as expected

@ben-githubs ben-githubs requested a review from a team as a code owner December 19, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant