Split 'Standard.BruteForceByIP' into IP and Username versions #1457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Hakmiller noticed that our
Standard.BruteForceByIP
rule is actually checking by username, not IP. He requested we either make the title clearer, or adjust the rule to check by IP instead. Since changing a rule's title has numerous consequences, I've instead decided to adjust the logic to check by IP, and copied the existing logic to a new rule,Standard.BruteForceByUser
, so customers can keep the same behaviour if they wish.Changes
Standard.BruteForceByIP
Standard.BruteForceByUser
, which has the original logic ofStandard.BruteForceByIP
Testing