Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only skip last tx commit #13528

Merged
merged 1 commit into from
Dec 23, 2024
Merged

fix: only skip last tx commit #13528

merged 1 commit into from
Dec 23, 2024

Conversation

mattsse
Copy link
Collaborator

@mattsse mattsse commented Dec 23, 2024

this check is in a nested loop

for block in blocks
  for call in block.calls

we can only skip the commit if it is the last tx in the last block

@mattsse mattsse requested a review from Rjected as a code owner December 23, 2024 20:22
@mattsse mattsse requested review from klkvr and removed request for Rjected December 23, 2024 20:22
@mattsse mattsse added C-bug An unexpected or incorrect behavior A-rpc Related to the RPC implementation labels Dec 23, 2024
@mattsse mattsse enabled auto-merge December 23, 2024 20:24
Copy link
Collaborator

@klkvr klkvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops

Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #13528 will degrade performances by 11.58%

Comparing matt/only-skip-last-tx (66e9ce0) with main (3e15ae3)

Summary

❌ 1 regressions
✅ 72 untouched benchmarks
🆕 4 new benchmarks
⁉️ 4 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main matt/only-skip-last-tx Change
`prefix set preload size: 10 input size: 10 Vec with custom cursor lookup`
⁉️ `prefix set preload size: 1000 input size: 1000 BTreeSet with BTreeSet:range lookup`
⁉️ `prefix set preload size: 1000 input size: 1000 BTreeSet with Iterator:any lookup`
⁉️ `prefix set preload size: 1000 input size: 1000 Vec with binary search lookup`
⁉️ `prefix set preload size: 1000 input size: 1000 Vec with custom cursor lookup`
🆕 `prefix set preload size: 1000 input size: 997 BTreeSet with BTreeSet:range lookup`
🆕 `prefix set preload size: 1000 input size: 997 BTreeSet with Iterator:any lookup`
🆕 `prefix set preload size: 1000 input size: 997 Vec with binary search lookup`
🆕 `prefix set preload size: 1000 input size: 997 Vec with custom cursor lookup`

@mattsse mattsse added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit 8579c08 Dec 23, 2024
43 of 44 checks passed
@mattsse mattsse deleted the matt/only-skip-last-tx branch December 23, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Related to the RPC implementation C-bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants