Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move EventSender out of BeaconConsensusEngineHandle #13533

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Dec 23, 2024

EventSender needs primitives generic which leaks it into some types which operate exclusively on EngineTypes

it is not used anywhere so decided to just remove from here for now

Copy link

codspeed-hq bot commented Dec 23, 2024

CodSpeed Performance Report

Merging #13533 will not alter performance

Comparing klkvr/move-engine-sender (6e1a8d8) with main (8579c08)

Summary

✅ 73 untouched benchmarks
🆕 4 new benchmarks
⁉️ 4 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main klkvr/move-engine-sender Change
🆕 `prefix set preload size: 1000 input size: 1000 BTreeSet with BTreeSet:range lookup`
🆕 `prefix set preload size: 1000 input size: 1000 BTreeSet with Iterator:any lookup`
🆕 `prefix set preload size: 1000 input size: 1000 Vec with binary search lookup`
🆕 `prefix set preload size: 1000 input size: 1000 Vec with custom cursor lookup`
⁉️ `prefix set preload size: 1000 input size: 999 BTreeSet with BTreeSet:range lookup`
⁉️ `prefix set preload size: 1000 input size: 999 BTreeSet with Iterator:any lookup`
⁉️ `prefix set preload size: 1000 input size: 999 Vec with binary search lookup`
⁉️ `prefix set preload size: 1000 input size: 999 Vec with custom cursor lookup`

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, this is a lot better

@mattsse mattsse added this pull request to the merge queue Dec 23, 2024
@mattsse mattsse added the A-sdk Related to reth's use as a library label Dec 23, 2024
@mattsse mattsse removed this pull request from the merge queue due to a manual request Dec 23, 2024
@klkvr klkvr added this pull request to the merge queue Dec 23, 2024
Merged via the queue into main with commit c6d42ad Dec 23, 2024
43 of 44 checks passed
@klkvr klkvr deleted the klkvr/move-engine-sender branch December 23, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants