Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: introduce OpPooledTransaction #13548

Merged
merged 1 commit into from
Dec 25, 2024
Merged

feat: introduce OpPooledTransaction #13548

merged 1 commit into from
Dec 25, 2024
+183 −9

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Dec 24, 2024

For now unused but ready to be plugged into OpPool

mattsse
mattsse approved these changes Dec 25, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

we def need this as a new type, especially because we need to add the support for transaction conditional

@mattsse mattsse added this pull request to the merge queue Dec 25, 2024
@mattsse mattsse added A-tx-pool Related to the transaction mempool A-sdk Related to reth's use as a library labels Dec 25, 2024
Merged via the queue into main with commit cec31ad Dec 25, 2024
44 checks passed
@mattsse mattsse deleted the klkvr/op-pooled-tx branch December 25, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

Assignees
No one assigned
Labels
A-sdk Related to reth's use as a library A-tx-pool Related to the transaction mempool
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@klkvr @mattsse