Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: deduplicate FillTxEnv traits #13551

Merged
merged 2 commits into from
Dec 25, 2024
Merged

chore: deduplicate FillTxEnv traits #13551

merged 2 commits into from
Dec 25, 2024

Conversation

klkvr
Copy link
Collaborator

@klkvr klkvr commented Dec 24, 2024

Right now we have 2 identical FillTxEnv traits with different implementations for TransactionSigned

This PR only keeps the one defined on reth_primitives_traits and updates impl for it to be the same as the one that was used before

Copy link

codspeed-hq bot commented Dec 24, 2024

CodSpeed Performance Report

Merging #13551 will degrade performances by 20.23%

Comparing klkvr/dedup-fill-traits (32b2633) with main (c6e38be)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 75 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main klkvr/dedup-fill-traits Change
`hash builder[init size 10000 update size 100 num updates 1]` 10.1 ms
`sparse trie[init size 10000 update size 100 num updates 3]` 10.1 ms

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool,

this trait itself is a bit horrible and only really necessary because we usually call this via tx.fill(evm.tx_env_mut()) which should change shortly

@mattsse mattsse added this pull request to the merge queue Dec 25, 2024
Merged via the queue into main with commit 00c8ec7 Dec 25, 2024
42 of 43 checks passed
@mattsse mattsse deleted the klkvr/dedup-fill-traits branch December 25, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants