feat: use new engine in e2e tests for OP #13558
Open
+18
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klkvr
commented
Dec 25, 2024
| @@ -43,13 +43,19 @@ async fn can_sync() -> eyre::Result<()> { | |||
| .update_optimistic_forkchoice(canonical_chain[tip_index - reorg_depth]) | |||
| .await?; | |||
| second_node | |||
| .wait_block((tip - reorg_depth) as u64, canonical_chain[tip_index - reorg_depth], true) | |||
| .wait_block((tip - reorg_depth) as u64, canonical_chain[tip_index - reorg_depth], false) | |||
There was a problem hiding this comment.
this marks whether we need to wait for Finish stage to advance which might not happen if persistence threshold is not reached
klkvr
commented
Dec 25, 2024
| .await?; | ||
| second_node.engine_api.canonical_stream.next().await.unwrap(); | ||
|
|
||
| // On third node, sync optimistically up to block number 90a | ||
| // Trigger backfil sync until block 80 |
There was a problem hiding this comment.
This seems to be an edge case for new engine. If we sync to the tip via backfill sync and then a reorg happens, we're not going to be able to process it because we will be missing trie updates in in-memory state.
I guess this is unlikely because we'd mostly use backfill sync to reach finalized block
CodSpeed Performance ReportMerging #13558 will degrade performances by 10.37%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaults to new engine when running op e2e tests.
This required some changes to a test