Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(revm): Add address inspector #4162

Closed
wants to merge 5 commits into from

Conversation

perama-v
Copy link

@perama-v perama-v commented Aug 11, 2023

Description

Progress toward

This PR explores extracting addresses for the address namespace during the Execution stage via a new inspector.
This would be gated by the namespace flag.

Changes made

  • New AddressInspector struct
  • Add test case that extracts addresses using the inspector
  • Connect the addresses found by the inspector to Execution stage
  • Left a TODO where a separate PR can store addresses in a DB.
  • Get addresses from non-evm sources (tx sender, recipient), and from block (block producer, withdrawals)
  • Add functions for extracting possible addresses from bytes and bytes32, includes test cases from the spec

To do

  • Identify and remove redundancy in the address search (e..g, A contract read is a superset of a log)
  • Activate the inspector when the namespace flag is enabled

@perama-v
Copy link
Author

As pointed out in the tracking issue, there is logical redundancy.

A contract read is a superset of a log.

At present, addresses are aggregated naively according to the locations defined in the spec. However some may be skipped, for example the origin address of a log does not need to be recorded as logs can only happen if a call to that address has been made. So this can be skipped.

@github-actions github-actions bot added the S-stale This issue/PR is stale and will close with no further activity label Oct 15, 2023
@rkrasiuk rkrasiuk added M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity and removed S-stale This issue/PR is stale and will close with no further activity labels Oct 19, 2023
@gakonst
Copy link
Member

gakonst commented Jan 9, 2024

Closing this as stale, we'll re-incorporate these ideas as we venture into custom stages with Reth CLI Extensions and the Declarative Node Builder API that @mattsse is spearheading.

@gakonst gakonst closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M-prevent-stale Prevents old inactive issues/PRs from being closed due to inactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants