feat(rpc): add eth_multicallV1
#5596
Conversation
DoTheBestToGetTheBest
requested review from
mattsse,
Rjected and
Evalir
as code owners
ty lot |
|
@mattsse does this look better? |
| multicall_bundle: Bundle, | ||
| state_context: Option<StateContext>, | ||
| mut state_override: Option<StateOverride>, | ||
| ) -> EthResult<Vec<EthCallResponse>> { |
There was a problem hiding this comment.
this is just the same as call_many?
so atm we don't need this function and can reuse call_many instead
There was a problem hiding this comment.
this is just the same as call_many?
so atm we don't need this function and can reuse call_many instead
hey ty for your review, you means i should directly call the function call_many inside this function ?
There was a problem hiding this comment.
yes, at least for now
ty so much, very greatful from your part all these review. should be fine now
| /// Executes complex RPC calls to Ethereum nodes | ||
|
|
||
| pub async fn eth_multicall_v1( |
There was a problem hiding this comment.
| /// Executes complex RPC calls to Ethereum nodes | |
| pub async fn eth_multicall_v1( | |
| /// Executes complex RPC calls to Ethereum nodes. | |
| /// Ref: <https://github.com/ethereum/execution-apis/pull/484> | |
| pub async fn eth_multicall_v1( |
| @@ -18,6 +18,15 @@ pub trait EthApi { | |||
| #[method(name = "protocolVersion")] | |||
| async fn protocol_version(&self) -> RpcResult<U64>; | |||
|
|
|||
| /// Executes complex RPC calls to Ethereum nodes | |||
| #[method(name = "ethMulticallV1")] | |||
There was a problem hiding this comment.
jsonrpc method names are case sensitive and eth prefix is already specified on the trait
| #[method(name = "ethMulticallV1")] | |
| #[method(name = "multicallV1")] |
| @@ -51,6 +51,17 @@ where | |||
| EthApiSpec::protocol_version(self).await.to_rpc_result() | |||
| } | |||
|
|
|||
| /// Handler for ! `eth_MultiCallV1` | |||
There was a problem hiding this comment.
| /// Handler for ! `eth_MultiCallV1` | |
| /// Handler for ! `eth_multicallV1` |
onbjerg
changed the title
eth_multicallv1
onbjerg
changed the title
eth_multicallv1eth_multicallV1
ref : #5586