feat(ci): add cfg check #7965
Merged
feat(ci): add cfg check #7965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
approved these changes
Apr 29, 2024
onbjerg
requested changes
Apr 29, 2024
|
thanks @DaniPopes for being a rust encyclopaedia and telling us ab this awesome check, will save me one or two fml moments here-forth when I forget to add |
Co-authored-by: Oliver Nordbjerg <[email protected]>
mattsse
approved these changes
Apr 29, 2024
mw2000
pushed a commit
to mw2000/reth
that referenced
this pull request
Jun 5, 2024
Co-authored-by: Oliver Nordbjerg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks if
cfgattribute is used correctly. This for example catches if a feature is used in lib, that isn't in manifest.