fix getJpegInfo to skip DHT marker
#3667
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @HackbrettXXX, is it possible to check and merge this fix ? We are multiple people facing this issue. I can provide an image that creates the issue when used using addImage if you want me to. Thanks. |
|
Linking PR to issue. Fixes #3318 |
|
Hello @MrRio, can you or someone else review and merge this request ? Thanks |
|
We also had this issue and this PR fixes it. Can someone merge this, please? |
rnigro-rwb
force-pushed
the
3318-jpeg-size-determination
branch
from
312ae22 to
0d4bddd
Compare
|
To add to insight to this fix, the original As you can see here, Define Huffman table marker (FFC4), 0xC4 is a marker for the Huffman table. My fix skips |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3318.
getJpegInfonow skips the DHT marker (0xc4) because that marker is not a SOF (start of frame) marker and therefore the segment to follow does not have the size information.