Add support for global() function in CSS Modules animation names #860
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lightningcss localalizes animations for css modules with quite well - for example
Input:
Output:
However in some cases we were running into issues with animation names getting localized when we didn't want them to. This is problamatic when using third-party animation libraries or sharing animations across components.
For selectors there is the
:global
specifier so we added support for aglobal()
function that can be used directly in animation properties to match with postcss-modules-local-by-default: css-modules/postcss-modules-local-by-default#76Input:
Output:
The current solution handles the
global
function in properties/custom.rs but I'm open to moving it if there's a better spot for this logicPlease let me know what you think