Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use clone_from() as it performs better in some cases #520

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Use clone_from() as it performs better in some cases #520

merged 2 commits into from
Sep 30, 2023

Conversation

nitisht
Copy link
Member

@nitisht nitisht commented Sep 29, 2023

Fixes #519

Description

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

trueleo
trueleo previously approved these changes Sep 29, 2023
View reviewed changes
@nitisht nitisht merged commit 3d6e8c8 into parseablehq:main Sep 30, 2023
4 of 5 checks passed
@nitisht nitisht deleted the fix-deepsource branch September 30, 2023 11:16
@github-actions github-actions bot locked and limited conversation to collaborators Sep 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@trueleo trueleo trueleo left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(RS-W1070) Found use of .clone() in assignment
2 participants
@nitisht @trueleo