New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conditional compilation for CORS config #542

Merged

nitisht merged 4 commits into parseablehq:main from trueleo:cargo-feature

Oct 26, 2023

Contributor

trueleo commented Oct 26, 2023

Description

Remove pyroscope from debug feature
Use debug feature for permissive CORS config

This PR has:

been tested to ensure log ingestion and log query works.
added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
added documentation for new or modified features or behaviors.

trueleo added 4 commits

October 26, 2023 13:37


          Remove Pyroscope

35a8ac8


          Conditional compile CORS config

8e69226


          Fix fmt

eaf17c4

Fix

7071a86

trueleo force-pushed the cargo-feature branch from e647e4c to 7071a86 Compare

October 26, 2023 08:08

nitisht merged commit e7b15c1 into parseablehq:main

5 checks passed

github-actions bot locked and limited conversation to collaborators

trueleo deleted the cargo-feature branch

October 31, 2023 13:45

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet