Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move CORS layer to a seperate feature #545

Closed
wants to merge 5 commits into from
Closed

Move CORS layer to a seperate feature #545

wants to merge 5 commits into from

Conversation

trueleo
Copy link
Contributor

@trueleo trueleo commented Oct 30, 2023 •
edited
Loading

Description

This PR removes CORS layer from livetail and actix web. CORS will be available as a separate feature called permissive_cors and this feature is included in debug build as well.

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@trueleo trueleo changed the title Fix cors Move CORS layer to a seperate feature Oct 30, 2023
@trueleo trueleo closed this Oct 30, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 30, 2023
@trueleo trueleo deleted the fix_cors branch October 31, 2023 13:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@trueleo