Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple fixes on server #753

Merged
merged 2 commits into from
Apr 10, 2024
Merged

multiple fixes on server #753

merged 2 commits into from
Apr 10, 2024

Conversation

nikhilsinhaparseable
Copy link
Contributor

  1. fixed banner spacing
  2. modified server mode: All to Standalone, Ingest to Distributed (Ingest), Query to Distributed (Query)
  3. updated server mode in about API response
  4. updated logic for env var P_INGESTOR_URL to use HOSTNAME and PORT from env
  5. remvoed put cache api from querier
  6. added put cache api to ingester to enable caching

Fixes #XXXX.

Description

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@nikhilsinhaparseable
multiple fixes on server:
70937d4 
1. fixed banner spacing
2. modified server mode: All to Standalone, Ingest to Distributed (Ingest), Query to Distributed (Query)
3. updated server mode in about API response
4. updated logic for env var P_INGESTOR_URL to use HOSTNAME and PORT from env
5. remvoed put cache api from querier
6. added put cache api to ingester
@nikhilsinhaparseable
added below fixes:
9a48169 
1. renamed ingester to ingestor
2. corrected cache flow for ingestors and standalone
3. removed query, other logstream apis for ingestors
@nitisht nitisht requested review from nitisht and Eshanatnight April 10, 2024 13:57
@nitisht nitisht merged commit 0d5f1fd into parseablehq:main Apr 10, 2024
6 checks passed
nikhilsinhaparseable added a commit to nikhilsinhaparseable/parseable that referenced this pull request Apr 20, 2024
@nikhilsinhaparseable
multiple fixes on server (parseablehq#753)
e11f9fb 
1. fixed banner spacing
2. modified server mode: All to Standalone, Ingest to Distributed (Ingest), Query to Distributed (Query)
3. updated server mode in about API response
4. updated logic for env var P_INGESTOR_URL to use HOSTNAME and PORT from env
5. remove put cache api from querier
6. added put cache api to ingestor
7. renamed ingester to ingestor
8. corrected cache flow for ingestors and standalone
9. removed query, other logstream apis for ingestors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitisht nitisht Awaiting requested review from nitisht

@Eshanatnight Eshanatnight Awaiting requested review from Eshanatnight

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikhilsinhaparseable @nitisht