Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Cache fix distributed #767

Merged
merged 3 commits into from
Apr 19, 2024

Conversation

nikhilsinhaparseable
Copy link
Contributor

cache can be enabled from querier UI
querier calls the PUT /cache API to all ingesters
at ingester, first checks if stream exists,
if not found in local map, check in S3 and create stream
then checks if caching env vars are set
if yes, add cache_enabled flag to STREAM_INFO
and update its stream.json in S3

Fixes #764

cache can be enabled from querier UI
querier calls the PUT /cache API to all ingesters
at ingester, first checks if stream exists,
if not found in local map, check in S3 and create stream
then checks if caching env vars are set
if yes, add cache_enabled flag to STREAM_INFO
and update its stream.json in S3

Note: Query still doesn't use the cached data

Fixes: 764
Copy link
Contributor

@Eshanatnight Eshanatnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@nitisht nitisht merged commit bb849d1 into parseablehq:main Apr 19, 2024
6 checks passed
nikhilsinhaparseable added a commit to nikhilsinhaparseable/parseable that referenced this pull request Apr 20, 2024
caching for distributed mode can be 
enabled from querier UI. Querier calls the PUT 
/cache API to all ingestors. An ingestor, first checks 
if stream exists, if not found in local map, checks 
in S3 and creates stream. Then checks if caching 
env vars are set. If yes, add cache_enabled flag to 
STREAM_INFO and update its stream.json in S3

Fixes: parseablehq#764
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: Caching for Distributed
3 participants