Multiple Fixes for Distributed Deployments #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- to subtract the size of the arrow file removed from staging fix for GET /cache - to return error in case global cache is not set
nikhilsinhaparseable
force-pushed
the
fix-staging-size-metrics
branch
from
122dd43 to
b5fa070
Compare
from standalone to distributed deployments
nikhilsinhaparseable
changed the title
from standalone to distributed - querier should cleanup its snapshot upon retention
…f retention activity and ingestor's stream.json did not get updated now when ingestion happens from ingestor, local to storage sync fails with error - Manifest found in snapshot but not in object-storage change done is to create the manifest but not update the snapshot because snapshot already has the manifest entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change done is to return error if global cache is not set, if set return true/false
change done is to add querier manifest.json also while checking for all manifests related to the time filter