-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic endpoints #967
Dynamic endpoints #967
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
Can you look at the CI failures @TomBebb ? |
server/Cargo.toml
Outdated
@@ -106,6 +106,7 @@ path-clean = "1.0.1" | |||
prost = "0.13.3" | |||
prometheus-parse = "0.2.5" | |||
sha2 = "0.10.8" | |||
uuid = { version = "1.11.0", features = ["v4", "fast-rng"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we use ulid
instead - already being used in other places
Done |
@TomBebb we need to add a few validations and update a few things in this PR -
do let me know if you need further clarification to the points mentioned here Thanks! |
@nikhilsinhaparseable Cool, working on that now |
What should the difference be between hitting the cache duration and waiting a minute be? |
Implemented using advised notes, please can someone re-review? |
@TomBebb below are the review comments -
I will update if I find anything else. |
@nikhilsinhaparseable I cannot reproduce the aggregate query issue on my commit before master merge, but can in commits since and on master. |
@nikhilsinhaparseable There is a datafusion byte serialization crate datafusion_proto but it only supports expression conversion to / from bytes for now. I can work around that or just shove the raw text query in the parquet file. |
@TomBebb please update if the PR is ready for review |
Fixes #370
Description
Adds support for dynamic queries by periodically re-fetching the query given.
Associates each dynamic query with a UUID.
Uses a static ref map to associate the UUIDs with the latest result.
This PR has:
/claim #370