Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up parts of the codebase #981

Merged
merged 26 commits into from
Dec 20, 2024
Merged

Conversation

de-sh
Copy link
Contributor

@de-sh de-sh commented Nov 2, 2024

Fixes #XXXX.

Summary

  • De-serialize Mode, don't compare strings.
  • to_string runs to_vec, so just do that.
  • Custom SSEError type for readability.
  • Fewer hard-coded serde renames.
  • fix: there are a 1000milis every sec.
  • De-serialize Compression to not hard-code matching.
  • Space used/available in hottier is not optional.
  • Only construct the ObjectStorage client once.
  • Reorganize as methods to save on cost of copy.
  • Mutate only the file_path on windows.
  • DiskUtil replaces the tuple (total_disk_space, available_disk_space, used_disk_space).
  • Save on cost of cloning within EventFormat

This PR has:

  • been tested to ensure log ingestion and log query works.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@de-sh de-sh marked this pull request as ready for review November 2, 2024 18:26
server/src/handlers/http/modal/mod.rs Outdated Show resolved Hide resolved
server/src/handlers/http/modal/ingest_server.rs Outdated Show resolved Hide resolved
server/src/handlers/http/modal/query_server.rs Outdated Show resolved Hide resolved
server/src/handlers/http/modal/server.rs Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Nov 20, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@de-sh
Copy link
Contributor Author

de-sh commented Nov 21, 2024

I have read the CLA Document and I hereby sign the CLA

src/hottier.rs Show resolved Hide resolved
@de-sh de-sh requested a review from nitisht December 8, 2024 09:08
@coveralls
Copy link

coveralls commented Dec 12, 2024

Pull Request Test Coverage Report for Build 12433752181

Details

  • 50 of 500 (10.0%) changed or added relevant lines in 21 files are covered.
  • 9 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.06%) to 11.595%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/analytics.rs 0 1 0.0%
src/storage/azure_blob.rs 0 1 0.0%
src/storage/localfs.rs 0 1 0.0%
src/storage/staging.rs 0 1 0.0%
src/event/format/mod.rs 8 10 80.0%
src/handlers/http/modal/ingest_server.rs 0 2 0.0%
src/storage/object_storage.rs 0 3 0.0%
src/handlers/http/logstream.rs 0 4 0.0%
src/utils/json/mod.rs 13 17 76.47%
src/cli.rs 0 6 0.0%
Files with Coverage Reduction New Missed Lines %
src/storage/s3.rs 1 0.0%
src/handlers/http/logstream.rs 1 1.56%
src/query/stream_schema_provider.rs 2 26.9%
src/hottier.rs 5 0.0%
Totals Coverage Status
Change from base Build 12411844504: 0.06%
Covered Lines: 2092
Relevant Lines: 18043

💛 - Coveralls

Copy link
Member

@nitisht nitisht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nitisht nitisht merged commit b277775 into parseablehq:main Dec 20, 2024
6 checks passed
@de-sh de-sh mentioned this pull request Dec 20, 2024
3 tasks
@de-sh de-sh deleted the refactor branch December 20, 2024 19:10
nitisht pushed a commit that referenced this pull request Dec 21, 2024
Fixes type incompatibility that stems from merging #1021 after #981
parmesant pushed a commit to parmesant/parseable that referenced this pull request Dec 24, 2024
parmesant pushed a commit to parmesant/parseable that referenced this pull request Dec 24, 2024
Fixes type incompatibility that stems from merging parseablehq#1021 after parseablehq#981
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants