-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: clean up parts of the codebase #981
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-sh
commented
Nov 2, 2024
de-sh
commented
Nov 2, 2024
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
de-sh
commented
Nov 21, 2024
I have read the CLA Document and I hereby sign the CLA |
de-sh
commented
Dec 7, 2024
Pull Request Test Coverage Report for Build 12433752181Details
💛 - Coveralls |
nitisht
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
nitisht
pushed a commit
that referenced
this pull request
Dec 21, 2024
parmesant
pushed a commit
to parmesant/parseable
that referenced
this pull request
Dec 24, 2024
parmesant
pushed a commit
to parmesant/parseable
that referenced
this pull request
Dec 24, 2024
Fixes type incompatibility that stems from merging parseablehq#1021 after parseablehq#981
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #XXXX.
Summary
Mode
, don't compare strings.to_string
runsto_vec
, so just do that.SSEError
type for readability.Compression
to not hard-code matching.ObjectStorage
client once.file_path
on windows.DiskUtil
replaces the tuple(total_disk_space, available_disk_space, used_disk_space)
.EventFormat
This PR has: