Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move to node:fs/promises #1329

Merged
merged 1 commit into from
Jun 28, 2024
Merged

feat: move to node:fs/promises #1329

merged 1 commit into from
Jun 28, 2024

Conversation

43081j
Copy link
Collaborator

@43081j 43081j commented Jun 25, 2024

Moves to using node:fs/promises rather than using promisify manually.

@43081j
Copy link
Collaborator Author

43081j commented Jun 25, 2024

going to try fix this pesky windows failure while im in here 👍 lets not merge until i have, or i've given up 😂

@43081j 43081j force-pushed the async-fs branch 5 times, most recently from 7e4587c to d92fb64 Compare June 25, 2024 09:40
Moves to using `node:fs/promises` rather than using `promisify`
manually.
@paulmillr
Copy link
Owner

@43081j can we make a list of whats needed for v4 in your opinion?

i want to ditch v3 bc i’m tired of ppl reporting “vulnerabilities”

@43081j
Copy link
Collaborator Author

43081j commented Jun 26, 2024

@paulmillr sure ill try find some time this week to list whats left

the main blocker is this windows test, which im on the verge of fixing. almost certainly a timing issue in tests rather than anything wrong with the source

i can at least recreate it locally now, so will get around to fixing it eventually 👍

off the top of my head, the TLDR of whats left:

  • fix this windows test failure (whether it be a test problem or an actual bug)
  • start testing usage of it in some large projects (storybook, vite, maybe)
  • leave readdirp for now, moving to node's own recursive: true can happen another time

@paulmillr
Copy link
Owner

ok let's prepare for the release later this week.

@paulmillr paulmillr merged commit c8c3ff2 into paulmillr:v4 Jun 28, 2024
8 of 10 checks passed
@43081j 43081j deleted the async-fs branch June 28, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants