Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: failed snapshot comparison halts release #1166

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jadutter
Copy link
Contributor

@jadutter jadutter commented Dec 19, 2024

Description

  • Removed continue-on-error to prevent failed snapshot comparisons from allowing Release workflow

This PR should be considered after snapshots have been updated.

Screenshots

Testing instructions

@jadutter
Copy link
Contributor Author

Snapshots Failing Are Unrelated To This PR Change

I believe many of the snapshots (like so)

● IT > text (Test Count: 66) › > DEV0000ITPLNQ (Test Count: 22) › Small viewport › IT/DEV0000ITPLNQ/text/logo.type-primary_text.position-left

Expected image to match or be a close match to snapshot but was 3.9174484052532836% different from snapshot (522 differing pixels).
See diff for details: tests/functional/snapshots/IT/DEV0000ITPLNQ/text/diff_output/logo.type-primary_text.position-left-200-diff.png

are failing because of this

ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see actions/runner-images#10636

rather than it being related to the changes made in the workflow by this PR.

The issue mentions

Rollout will begin on December 5th and will complete on January 17th, 2025.

So, there's the potential that these snapshots were generated on separate systems.

Checking against this CI run, I see that our actions were using ubuntu 22.04.5 for ubuntu@latest, but are now using ubuntu 24.04.1

Preivous Run

Screenshot 2024-12-20 at 2 34 20 PM

Current Run

Screenshot 2024-12-20 at 2 34 54 PM

@jadutter jadutter added the DO NOT MERGE Requires a change from some external dependency or service label Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Requires a change from some external dependency or service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant