Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for new uuid version #16

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix for new uuid version #16

wants to merge 1 commit into from

Conversation

donatj
Copy link

@donatj donatj commented Sep 3, 2018

Attempting to build is currently throwing the following message.

# github.com/pdf/golifx/common
common/subscription.go:69:23: multiple-value uuid.NewV4() in single-value context

The interface of the satori/go.uuid package changed such that there is the potential to return an error. I've made the code simply panic in this case as this is something that should basically never happen unless the random number generator fails - in which case you likely have bigger problems.

@pdf
Copy link
Owner

pdf commented Sep 3, 2018

If you vendor the dependencies using glide, it should build - I should probably update the docs and/or migrate to dep/vgo.

Will need to update the glide deps at a minimum to merge this, otherwise the build will be broken for users building with vendoring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants