Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix links in PR template #823

Merged
merged 4 commits into from
Dec 29, 2023
Merged

Fix links in PR template #823

merged 4 commits into from
Dec 29, 2023

Conversation

dmlls
Copy link
Contributor

@dmlls dmlls commented Oct 27, 2022 •
edited
Loading

Pull request

The relative links in the PR template don't work from the PR page. This can be confirmed by clicking on any of the links in the checklist.

How Has This Been Tested?

Ensuring the links redirect properly.

Checklist

  • I have read CONTRIBUTING.md.
  • I have added a concise human-readable description of the change to CHANGELOG.md.
  • I have tested that this fix is effective or that this feature works.
  • I have added docstrings to newly created methods and classes.
  • I have updated the README.md and the readthedocs documentation. Or verified that this is not necessary.

@dmlls dmlls marked this pull request as ready for review October 27, 2022 14:10
@pietermarsman pietermarsman added this pull request to the merge queue Dec 29, 2023
@pietermarsman
Copy link
Member

Thanks! This is great!

Merged via the queue into pdfminer:master with commit c85e9a3 Dec 29, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmlls @pietermarsman