Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #853: Extract 4-bits images from PDF #854

Closed
wants to merge 6 commits into from

Conversation

sheldonldev
Copy link

@sheldonldev sheldonldev commented Feb 3, 2023

Pull request

Please remove this paragraph and replace it with a description of your PR. Also include the issue that it fixes.

How Has This Been Tested?

Please remove this paragraph with a description of how this PR has been tested.

Checklist

  • I have read CONTRIBUTING.md.
  • I have added a concise human-readable description of the change to CHANGELOG.md.
  • I have tested that this fix is effective or that this feature works.
  • I have added docstrings to newly created methods and classes.
  • I have updated the README.md and the readthedocs documentation. Or verified that this is not necessary.

@pettzilla1
Copy link
Contributor

CV2 requires GTK which is a copy left package this contradicts the licence which pdfminer.six uses and would heavily restrict pdfminer.six's uses , It is not recommended to merge this in its current format. It would in addition fall foul of new requirements in pull request #819 which is currently waiting to be merged. please insure packages used have no copyleft dependencies

Copy link
Contributor

@pettzilla1 pettzilla1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the usage of copy left dependent packages , CV2 requires such packages and should make pdfminer copy left

@pietermarsman
Copy link
Member

@sheldonldev Thanks for your contribution and time!

@pettzilla1 Thanks for being strict on the licenses!

Not accepting this because of the copy left licence it requires. For more information, see the CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants