Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: codec error message #902

Merged
merged 6 commits into from
Jan 1, 2024
Merged

fix: codec error message #902

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
be6dab8
fix: codec error message
117503445 Jul 23, 2023
9ae857c
doc: changelog
117503445 Jul 23, 2023
1db7139
Merge branch 'master' into fix-codec-err-msg
pietermarsman Dec 28, 2023
ec2654b
Merge branch 'master' into fix-codec-err-msg
pietermarsman Jan 1, 2024
aa91f58
Fix chnagelog
pietermarsman Jan 1, 2024
1db89c3
Require no codec on text output
pietermarsman Jan 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

- Resolving mediabox and pdffont ([#834](https://github.com/pdfminer/pdfminer.six/pull/834))
- Keywords that aren't terminated by the pattern `END_KEYWORD` before end-of-stream are parsed ([#885](https://github.com/pdfminer/pdfminer.six/pull/885))
- `ValueError` wrong error message when specifying codec for text output ([#902](https://github.com/pdfminer/pdfminer.six/pull/902))

## [20231228]

Expand Down
4 changes: 3 additions & 1 deletion pdfminer/converter.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,8 +409,10 @@ def __init__(
)

# write() assumes a codec for binary I/O, or no codec for text I/O.
if self.outfp_binary == (not self.codec):
if self.outfp_binary and not self.codec:
raise ValueError("Codec is required for a binary I/O output")
if not self.outfp_binary and self.codec:
raise ValueError("Codec must not be specified for a text I/O output")

if text_colors is None:
text_colors = {"char": "black"}
Expand Down
Loading