Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes nix builder #107

Merged
merged 1 commit into from
Jan 12, 2024
Merged

fixes nix builder #107

merged 1 commit into from
Jan 12, 2024

Conversation

antoinerg
Copy link
Contributor

As far as I can tell, the following feature advertised in the README.md isn't working:

Packages can be fetched from a binary cache or built on the fly if necessary.

This PR resolves this!

@antoinerg antoinerg mentioned this pull request Jan 12, 2024
Closed
@RobbieBuxton
Copy link
Collaborator

Ah good spot! looks like a typo to me. I've checked it doesn't break anything on my machine so should be good for merge @elpdt852!

@elpdt852 elpdt852 added the ok-to-test Runs NixOS tests label Jan 12, 2024
@elpdt852 elpdt852 self-requested a review January 12, 2024 12:04
elpdt852
elpdt852 approved these changes Jan 12, 2024
View reviewed changes
Copy link
Collaborator

@elpdt852 elpdt852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t understand how this slipped through integration tests… good catch. I’ll have to investigate why it went unnoticed.

@elpdt852 elpdt852 merged commit ff0e45a into pdtpartners:main Jan 12, 2024
13 checks passed
@antoinerg
Copy link
Contributor Author

I don’t understand how this slipped through integration tests… good catch. I’ll have to investigate why it went unnoticed.

@elpdt852 I think it is because the integration tests preload the VM with the images so the nix store is already populated!

@antoinerg antoinerg deleted the fix-nix-builder branch January 12, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpdt852 elpdt852 elpdt852 approved these changes

Assignees
No one assigned
Labels
ok-to-test Runs NixOS tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@antoinerg @RobbieBuxton @elpdt852