fixes k3s image pulling #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antoinerg
commented
Jan 20, 2024
Comment on lines
+19
to
+27
| _module.args.pkgs = let | ||
| # Creates a k3s overlay to get a recent version with the --image-service-endpoint flag | ||
| nixpkgs-unstable = import inputs.nixpkgs-unstable {inherit system;}; | ||
| k3sOverlay = final: prev: {k3s = nixpkgs-unstable.k3s;}; | ||
| in import inputs.nixpkgs { | ||
| inherit system; | ||
| # Apply default overlay to provide nix-snapshotter for NixOS tests & | ||
| # configurations. | ||
| overlays = [ self.overlays.default ]; | ||
| overlays = [ self.overlays.default k3sOverlay]; |
There was a problem hiding this comment.
In #108, @RobbieBuxton brings in a newer version of k3s in a different way. I'm not sure which is best 🤷
There was a problem hiding this comment.
It turns out that the approach in #108 isn't working. Please see #108 (comment) for details!
|
#108 might be better than this PR once it adds the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #102 by upgrading
k3sto a recent version that supports the--image-service-endpointflag. Then, we use that flag to pointk3stonix-snapshotter.