Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min go version to 1.20 to match k3s and tidy go.mod #111

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

elpdt852
Copy link
Collaborator

Working towards embedding nix-snapshotter in k3s.

@elpdt852 elpdt852 added the ok-to-test Runs NixOS tests label Feb 14, 2024
@elpdt852 elpdt852 force-pushed the feature/bump-go-1.20 branch from 5ff0b04 to 1c64d31 Compare February 14, 2024 09:08
@elpdt852 elpdt852 force-pushed the feature/bump-go-1.20 branch from 1c64d31 to 066a9fe Compare February 14, 2024 10:19
Copy link
Collaborator

@RobbieBuxton RobbieBuxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good LGTM!

@elpdt852 elpdt852 merged commit e9daec1 into main Feb 14, 2024
7 checks passed
@elpdt852
Copy link
Collaborator Author

@RobbieBuxton I've sent you an invite for this repo, that should give you the green check for reviews.

@RobbieBuxton
Copy link
Collaborator

RobbieBuxton commented Feb 14, 2024

@RobbieBuxton I've sent you an invite for this repo, that should give you the green check for reviews.

@elpdt852 I accepted it before I approved the PR but didn't seem to get a green tick?

@elpdt852
Copy link
Collaborator Author

@RobbieBuxton I've further bumped your permissions, let's see if that fixes things.

@elpdt852 elpdt852 deleted the feature/bump-go-1.20 branch February 14, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Runs NixOS tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants