Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for gVisor #125

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Add support for gVisor #125

merged 1 commit into from
Feb 24, 2024

Conversation

elpdt852
Copy link
Collaborator

@elpdt852 elpdt852 commented Feb 18, 2024

Fix #121

I’m keen on getting gVisor working because that opens the door for other runtimes. Turns out, we can get it working for both rootful & rootless modes.

See: https://gvisor.dev/docs/user_guide/containerd/quick_start/

New options

  • New options for containerd & containerd.rootless
virtualisation.containerd = {
  enable = true;
  nixSnapshotterIntegration = true;
  # Configures containerd settings for gVisor & adds pkgs.gvisor to containerd PATH
  # Also wraps `runsc` appropriately for rootless mode.
  # See: https://github.com/google/gvisor/issues/311#issuecomment-1121668954
  gVisorIntegration = true;
  # Sets the default CRI runtime to `runsc`
  defaultRuntime = "runsc";
}

@elpdt852 elpdt852 force-pushed the feature/gvisor-integration branch from 8c58346 to 639ae57 Compare February 19, 2024 14:09
@elpdt852 elpdt852 added the ok-to-test Runs NixOS tests label Feb 19, 2024
@elpdt852 elpdt852 marked this pull request as ready for review February 19, 2024 14:17
RobbieBuxton
RobbieBuxton previously approved these changes Feb 19, 2024
Copy link
Collaborator

@RobbieBuxton RobbieBuxton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, once tests are passing!

@elpdt852
Copy link
Collaborator Author

I'm able to run the test on my machine successfully but not on our github action runners. Seems like dmesg is blocked by something (KVM?)

@elpdt852 elpdt852 force-pushed the feature/gvisor-integration branch from 871ca8c to 188062d Compare February 23, 2024 15:57
@elpdt852 elpdt852 force-pushed the feature/gvisor-integration branch from 188062d to f7ca6b9 Compare February 23, 2024 23:57
@elpdt852 elpdt852 merged commit 2df4682 into main Feb 24, 2024
12 checks passed
@elpdt852 elpdt852 deleted the feature/gvisor-integration branch February 24, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Runs NixOS tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

extending the PATH envvar for containerd-rootless
2 participants