Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding shellcheck static analysis in CI #151

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

Buzz-Lightyear
Copy link
Contributor

This PR adds shellcheck static analysis for the shell scripts in this repo and addresses the warnings currently present:

In ./script/kind/usr/local/bin/kind-entrypoint.sh line 33:
exec $@
     ^-- SC2068 (error): Double quote array expansions to avoid re-splitting elements.


In ./script/rootless/common.sh line 1:
export REPO_DIR=$(git rev-parse --show-toplevel)
^-- SC2148 (error): Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
       ^------^ SC2155 (warning): Declare and assign separately to avoid masking return values.
...
...

@Buzz-Lightyear Buzz-Lightyear marked this pull request as draft December 9, 2024 16:54
@RobbieBuxton RobbieBuxton added the ok-to-test Runs NixOS tests label Dec 9, 2024
@elpdt852 elpdt852 self-requested a review December 12, 2024 19:29
@elpdt852 elpdt852 marked this pull request as ready for review December 12, 2024 19:29
Copy link
Collaborator

@elpdt852 elpdt852 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Buzz-Lightyear ! This looks good to me.

@elpdt852 elpdt852 merged commit 627b8ca into pdtpartners:main Dec 12, 2024
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Runs NixOS tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants