Make alerting_apps.dart screen easier to toggle apps #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DreadBoy
reviewed
May 26, 2021
| @@ -208,6 +208,27 @@ class CobbleTile extends StatelessWidget { | |||
| trailing: child, | |||
| ); | |||
|
|
|||
| factory CobbleTile.toggle({ | |||
There was a problem hiding this comment.
CobbleTile.app isn't used anywhere else except in AlertingApps screen in exactly this case, I think you can safely change it to work like you want. You don't have to create new factory, I think.
lib/ui/screens/alerting_apps.dart
Outdated
| var mutedPkgList = | ||
| mutedPackages.data?.value ?? []; | ||
| if (value) { | ||
| mutedPkgList.removeWhere( |
There was a problem hiding this comment.
This doesn't look like formatted code.
Having to target a tiny switch on each list item isn't very ergonomic; right handed users have to scrunch their hands to be able to access them and left handled users have to stretch their hands to be able to access them. Making the entire list delegate toggleable fixes this.
DreadBoy
approved these changes
May 27, 2021
|
@pontaoski It looks like you have a conflicts. Since your changes were approved, we can merge when you fix conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having to target a tiny switch on each list item isn't very ergonomic;
right handed users have to scrunch their hands to be able to access them
and left handled users have to stretch their hands to be able to access them.
Making the entire list delegate toggleable fixes this.