Separate the results of the checkboxgroup manipulator with a zero.

[keegan-lillo]

Fixes #13

[keegan-lillo]

@gregoiresage Does this work for you?

[gregoiresage]

I will try when I'll go back from holidays Saturday.
Thanks for the evolution!
Le 29 févr. 2016 3:16 AM, "keegan-lillo" [email protected] a
écrit :

@gregoiresage https://github.com/gregoiresage Does this work for you?

—
Reply to this email directly or view it on GitHub
#21 (comment).

[keegan-lillo]

Actually I wonder if maybe a \0 character might be a better separator. Colors are represented as numbers and black happens to be 0

[keegan-lillo]

@matthewtole what are your thoughts on the separator to use. I'd like to recycle this format for something like this: #4 in the future hence my concern over color values

[matthewtole]

I think that you're putting the solution to the problem in the wrong place. Instead of muddling up the results of the get() method, it would be better if the function that handles serialising the form to send to the watch handles this. That way it becomes a general solution that can be used by any component,

[keegan-lillo]

So in here https://github.com/pebble/clay/blob/master/src/scripts/lib/clay-config.js#L161 do something like

switch(typeof _settings[appKey]) {
  case 'array': 
    _settings[appKey] = Utils.addSeparators(item.get(), 0);
    break;
  default: 
    _settings[appKey] = item.get();
    break;
}

[keegan-lillo]

@matthewtole after discussing with @gregoiresage we have found that only string arrays needed to be split up with zeros. Number arrays will be sent as is. This will pave the way for future changes where we might want to send different types of arrays. Also arrays that have booleans in them will now be converted to ones and zeros.

[matthewtole]

Sounds good to me. 👍