Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore lint errors in boilerplate code. #38

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Conversation

hildjj
Copy link
Collaborator

@hildjj hildjj commented Mar 4, 2024

Fixes #37.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.95%. Comparing base (496a5c6) to head (0a4e575).
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##              main      #38      +/-   ##
===========================================
- Coverage   100.00%   99.95%   -0.05%     
===========================================
  Files           21       21              
  Lines         2136     2151      +15     
  Branches       243      248       +5     
===========================================
+ Hits          2136     2150      +14     
- Misses           0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hildjj
Copy link
Collaborator Author

hildjj commented Mar 4, 2024

I can't be bothered to figure out how to make the one last code branch get tested at the moment. Maybe someday when I replace the code generation with a sourcemapped templating engine.

@hildjj
Copy link
Collaborator Author

hildjj commented Mar 4, 2024

@nichtich please review, at least to take a look at the approach.

@nichtich
Copy link

nichtich commented Mar 5, 2024

It works on my machine :-) thanks!

@hildjj hildjj merged commit 11b9393 into peggyjs:main Mar 5, 2024
10 of 11 checks passed
@hildjj hildjj deleted the fix-37 branch March 5, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offset error when semicolons are disallowed
2 participants