Skip to content

Commit

Permalink
Mention that EKS isn't currently supported [#5]
Browse files Browse the repository at this point in the history
We'd like to support it eventually, but the current state of affairs
doesn't justify the effort.

Also removed some vestigial code that was copy-pasta from the kubeconfig
in drone-helm.
  • Loading branch information
ErinCall committed Dec 27, 2019
1 parent 3b78f01 commit 12c8e08
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
1 change: 1 addition & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ steps:
drone-helm3 is largely backwards-compatible with drone-helm. There are some known differences:
* `prefix` must be supplied via the `settings` block, not `environment`.
* EKS is not supported. See [#5](https://github.com/pelotech/drone-helm3/issues/5) for more information.
* Several settings no longer have any effect:
* `purge` -- this is the default behavior in Helm 3
* `recreate_pods`
Expand Down
12 changes: 0 additions & 12 deletions assets/kubeconfig.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,4 @@ users:
user:
{{- if .Token }}
token: {{ .Token }}
{{- else if .EKSCluster }}
exec:
apiVersion: client.authentication.k8s.io/v1alpha1
command: aws-iam-authenticator
args:
- "token"
- "-i"
- "{{ .EKSCluster }}"
{{- if .EKSRoleARN }}
- "-r"
- "{{ .EKSRoleARN }}"
{{- end }}
{{- end }}

0 comments on commit 12c8e08

Please sign in to comment.