Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement EKS support #5

Open
ErinCall opened this issue Dec 17, 2019 · 3 comments
Open

Implement EKS support #5

ErinCall opened this issue Dec 17, 2019 · 3 comments
Labels
drone-helm parity Feature parity with drone-helm enhancement New feature or request

Comments

@ErinCall
Copy link
Contributor

ErinCall commented Dec 17, 2019 •
edited
Loading

internal/helm.Config will need two new fields:

	EKSCluster string `envconfig:"EKS_CLUSTER"`
	EKSRoleARN string `envconfig:"EKS_ROLE_ARN"`
  • internal/run.InitKube and .kubeValues will need matching fields, so their values can be passed along to the kubeconfig template.
  • In InitKube.Prepare, if i.EKSCluster != "", i.Token should not be mandatory (and should probably be forbidden).

See also ipedrazas/drone-helm#80 for how this was implemented over there.
@ErinCall ErinCall added enhancement New feature or request drone-helm parity Feature parity with drone-helm labels Dec 17, 2019
@ErinCall ErinCall mentioned this issue Dec 17, 2019
Merged
@ErinCall ErinCall added this to the Version 1.0 milestone Dec 18, 2019
@ErinCall ErinCall assigned ErinCall and unassigned ErinCall Dec 23, 2019
ErinCall added a commit that referenced this issue Dec 27, 2019
@ErinCall
Put kubeconfig tests in a separate suite [#5]
d8d2e33 
As I started writing tests for EKS config, dealing with the repeated
setup/verification code was cumbersome. This should make it much easier
to add new tests.
ErinCall added a commit that referenced this issue Dec 27, 2019
@ErinCall
Implement EKS support [#5]
9c1ed84 
I *think* this will work, but without access to an EKS cluster I can't
actually test it.
@ErinCall
Copy link
Contributor Author

ErinCall commented Dec 27, 2019 •
edited
Loading

I'm moving this out of the v1 milestone:

  • We don't have an EKS cluster where I could verify the change
  • None of the publicly-visible .drone.ymls that use drone-helm are using EKS

I have a branch that's mostly complete, but it can just stay on the backburner until/unless we actually need it.

@ErinCall ErinCall removed this from the Version 1.0 milestone Dec 27, 2019
ErinCall added a commit that referenced this issue Dec 27, 2019
@ErinCall
Mention that EKS isn't currently supported [#5]
12c8e08 
We'd like to support it eventually, but the current state of affairs
doesn't justify the effort.

Also removed some vestigial code that was copy-pasta from the kubeconfig
in drone-helm.
@ErinCall ErinCall mentioned this issue Dec 27, 2019
Merged
4 tasks
josmo added a commit that referenced this issue Jan 1, 2020
@josmo
Merge pull request #40 from pelotech/no-eks-support
7d750f0 
Mention that EKS isn't currently supported [#5]
@Eguthrie3214
Copy link

Im currently testing this and have a use case for it. After I confirm that it works maybe you would want to merge it in?

@josmo
Copy link
Member

josmo commented Jan 8, 2020 •
edited
Loading

@Eguthrie3214 Definitely and let us know if you need any help :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
drone-helm parity Feature parity with drone-helm enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ErinCall @josmo @Eguthrie3214